Strange Loop Behavior...

...I have a rather large script, used to help organize landmarks.

If a landmark is found in the object's inventory that hasn't been properly added, I want the script to remove that landmark automatically to help prevent problems later on.

Here's what I have so far:




The trouble is that the loop is ending too early. I added a bunch of debug in there, but it just doesn't make sense.

Say I add 6 landmarks that haven't been "Accounted for." The script picks up the number of landmarks as 6, which is perfectly correct. But, for some reason, the loop thinks that "integer i" is equal to/greater than 6, even when it's only up to 4.

(I just used 4 as an example. It's usually some completely random number.)


So this is what all the debug might come up to:



I'm really stumped. Any help is appreciated. Thanks! ^_^

I add some things to test it, but its work for me

list InventoryLandmarks;
integer l;
integer index;

check_add_l()
{



    
         l=llGetInventoryNumber(INVENTORY_LANDMARK);
     index = 0;
    while (index < l) //Same as saying "while (i <= llGetInventoryNumber(INVENTORY_LANDMARK) - 1)"//
    {


        if (llListFindList(InventoryLandmarks, [llGetInventoryName(INVENTORY_LANDMARK, index)]) == -1)
        {
            
          
            if (llGetInventoryName(INVENTORY_LANDMARK, index) != "") llRemoveInventory(llGetInventoryName(INVENTORY_LANDMARK, index));
  llOwnerSay("Landmark Removed");
            }
        index++;
        llOwnerSay((string)index);

    }
    llOwnerSay("Loop exit");


    }

default
{
    state_entry()
    { 
llOwnerSay("ready to run!!");

}

touch_start(integer total_number)
{check_add_l();
    
}
}

Weird. I'll try recompiling.

This isn't strange, this is perfectly normal. It's just a typical case of "removing the rug under your feet".

You are using a growing index to walk a list and you shorten this list along the way. Sooner or later your index will point beyond the end of the list.

Let's take a short list:

list: ["A", "B"]
index: 0
content: "A"

We delete this item and increment the index:

list: ["B"]
index: 1
content: ?????

So... Always walk your inventory from end to start when you delete items in it.

integer i = llGetInventoryNumber(INVENTORY_LANDMARK) - 1;
while (i >= 0)
{
string name = llGetInventoryName(INVENTORY_LANDMARK, i);
if (llListFindList(InventoryLandmarks, [name]) == -1)
{
if (name != "" { llRemoveInventory(name); }
}
--i;
}

or decrement your max count and not your current count (that's really bad form, but sometimes it's necessary)

Ah, of course. What a stupid mistake.