Help with while loop

I am trying to create a function which moves a vehicle type object upwards on command to a certain height. I figured a while loop might be the best way to go about this so this is what I came up with

if (message == "surface")
{ 
   float surface = llWater();
   vector here = llGetPos();

while (here.z <= surface)
  {    
    llSetStatus(STATUS_PHYSICS, TRUE);
    llSetVehicleVectorParam (VEHICLE_LINEAR_MOTOR_DIRECTION ,<0,0,10>);//move up
   }
    llApplyImpulse(-llGetVel() * llGetMass(),FALSE);//counteract movement
    llSetStatus(STATUS_PHYSICS, FALSE);//disable physics to stay put
}

in my mind this should cause the vehicle to rise up to water level and then stop and turn non physical. Am I mising something or is there a better way to achieve this result. I want it to only happen when the user commands it (will eventually go in a dialogue menu).

The listen section is already implemented within the script using som eif statements to pull out other commands.

I thought this would slot straight in but things aren't working as I would expect. I have tried a few variations of this and it seems to either make the object go up forever or it sits in place.

you could just use a touch command to set it to +x amount of meters...

off the top of my head, the one I used is using the llSetTargetPos((GetTargetPos +<0,0,50>;

or something similar..that doesnt seem right... but you could set that, so that on rez the object only uses one touch, then goes to that height and changes state, then in the new state, touch wouldn't do anything. Unless you want it to be able to continue up at that set distance for each touch, then no state change is needed.

Wait, sorry, vehicle, dunno if it works then... sorry I forgot about that... I have no experience with vehicles =(

Nothing in the while loop changes the here.z or surface values - once you get into this, you'll never get out. Water probably won't change but you need to update 'here'.

If you did this...

float surface = llWater();
vector here = llGetPos();

while (here.z <= surface)
{ 
llSetStatus(STATUS_PHYSICS, TRUE);
llSetVehicleVectorParam (VEHICLE_LINEAR_MOTOR_DIRECTION ,<0,0,10>);//move up
here = llGetPos();
}

...it would be closer to what you're trying to do.

Not sure what you're doing is the right way to do things - you'll probably run through this loop 100 times before it has a chance to move - but I'll leave that to the vehicle people..

Take a look here:

/54/ca/210616/1.html

Thanks guys.

As Meade pointed out I am not updating the "here" position so the vehicle never new when it got above surface level. That makse sense as to why it just continued to rise when it was doing anything.

I shall try updating the script with a here=llGetPos(); once i get home from work.

I realise a while loop may not be the most elegant way to achieve what I'm going for but as the rest of the script is pretty cumbersome (and mostly not mine) I just wanted a small section of code to achieve this.

Maybe if I make it clearer what I'm doing that'll help.

Basically I'm making a submarine type vehicle. I got the behaviors to keep it under water while flying it but wanted to implement a "surface" command to get people up easily and stop the vehicle at surface level.

I'd at least stick in a small delay then. Maybe a llSleep (0.5) before you reset 'here' at the bottom of the loop.

You also don't need to be turning physics on in the loop. Turning it on before then loop the off after the loop may be a bit less laggy.

ahh ok. Good catch Meade. You're my new hero