can someone look at this newb script for me?

hi all,

Im no scripting whiz, im just trying to move windows up and down when clicked to open them, but whenever I rez the house with the windows using this script somewhere new, they fly off into outerspace when clicked.

I thought GetLocalPos would solve all that when its rezzed for the first time but so far no joy...:/

thanks!

PS: if someone csan show me how to incorporate a rot into this as well id be forever grateful!
___________________________________________

integer on; //is the switch on?
integer touched = TRUE;
open()
{
llSay(0, "Opening";
vector target = origpos + newpos;
while (llVecDist(llGetLocalPos(), target) > 0.001) llSetPos(target);
llSetTimerEvent(500);

}


close()
{
llSay(0, "Closing";
vector target = origpos;
while (llVecDist(llGetLocalPos(), target) > 0.001) llSetPos(target);
llSetTimerEvent(0);
}


vector origpos;
vector newpos = <0,0,-1.35>;

default
{
state_entry()
{
origpos = llGetLocalPos();
}

timer()
{
close();
}

touch_start(integer total_number)
{
if (touched)
{
open();
}

else
{
close();
}
touched = !touched;
}

}

reminder, scripts retain their variables even when picked up. May want an on_rez event to llResetScript();

Thanks Jokey, that solved the rezzing issue, but now I have a new problem

Say the house is bought and the new owner rezzes it.

No problem so far, everything works great, but say they decide its in the wrong place and move it to the left.
Next time the window slide script (for example) is activated it thinks the GetLocalPos origin is still where it was when it was rezzed, and the window flies over there, instead of sliding up and down in its new origin.

Whats the best way around this? im sure others have run into this all the time and there must be a simple solution.

Thanks!

PS; i was thinking about including a "button" that would llResetScript all the related house scripts after they had finished re-positioning it....is this the wrong tack? If its the right tack how do i do it?

vector origpos;
vector newpos = <0,0,-1.35>;
integer gopen = FALSE;

open() {
    llSay(0, "Opening");
    gopen = TRUE;
    origpos = llGetLocalPos();
    vector target = origpos + newpos;
    while (llVecDist(llGetLocalPos(), target) > 0.001) llSetPos(target);
    llSetTimerEvent(500);
}


close() {
    llSay(0, "Closing");
    gopen = FALSE;
    vector target = origpos;
    while (llVecDist(llGetLocalPos(), target) > 0.001) llSetPos(target);
    llSetTimerEvent(0);
}

default {
    state_entry() {
        origpos = llGetLocalPos();
    }

    on_rez(integer a) {
        llResetScript();
    }

    timer() {
        close();
    }

    touch_start(integer total_number) {
        if (gopen) {
            open();
        } else {
            close();
        }
    }
}

How's that work for you? It doesn't reset the script when moved, but it should just record where the window is when you open it.
If you want to reset it when you move, I think you want on_change, but I'm a litte occupied to go looking at the moment.

thanks! that did the trick

There's better ways than what I posted, but it was all I could think of off the top of my head while attempting to pay attention to the conversation on the phone.

If they move it while the window is open, there's gonna be some issues.

Might want to change it from moving to origpos and have it move the inverse of newpos? Or have it reset when change is detected... but I'm not sure if moving it would trigger the change event or not...

You could always do something like

vector gpos;
open() {
    llSay(0, "Opening");
    gopen = TRUE;
    origpos = llGetLocalPos();
    vector target = origpos + newpos;
    while (llVecDist(llGetLocalPos(), target) > 0.001) llSetPos(target);
    gpos = llGetLocalPos();
    llSetTimerEvent(500);
}

close() {
    llSay(0, "Closing");
    gopen = FALSE;
    if (gpos != llGetLocalPos())
        vector target = llGetLocalPos() - newpos;
    else
        vector target = origpos;
    while (llVecDist(llGetLocalPos(), target) > 0.001) llSetPos(target);
    llSetTimerEvent(0);
}

I haven't tested this but in my head it would work and wouldn't cause problems if you moved it while the windows were open. Though looking at the code it seems really bloated and could probabally be writen much much better.
There's too much repititon I think...


EDIT>> That looks a bit better. Still can probabally be done a lot better.