what is wrong here?

What is wrong here?

integer dialog_channel1;
integer dialog_channel2;
integer dialog_channel3;
key Key_ID;
string name;

default
{
    integer channel()
    { // top of script in functions
        //Gets Owner Key as integer
        return (integer)("0x"+llGetSubString((string)llGetOwnerKey(Key_ID),-16,-1)) ;
    }

    integer channel2()
    { // top of script in functions
        //Gets HASH of Owner Key and Owner Name as integer
        return (integer)("0x"+llGetSubString((string)llSHA1String ( Key_ID + name),-16,-1)) ;
    }

    integer CommandIs(string msg,string cmd)
    {
        return llSubStringIndex(msg,cmd) == 0;
    }
    ParseAndIssueCommand(string cmd)  //*** error refers to here
    {
        if (CommandIs(cmd,"title"))
        {
            string name = llGetSubString(cmd,6,-1);
            if (name == "title")
                llSetText("",<0,1,0>,1.0);
            else
                llSetText(name,<0,1,0>,1.0);
        }
    }


        state_entry()
        {
        {
            llListen(dialog_channel3,"",llGetOwner(),"");
        }
        }
            on_rez(integer start_param)
            {
                llResetScript();
            }
            listen(integer channel, string name, key id, string msg)
            {
                ParseAndIssueCommand(msg);
            //}
       
    //{
        //Private Channel Code
        Key_ID = llGetOwnerKey(ID);
        name = llKey2Name(Key_ID);
        dialog_channel1 = channel();
        dialog_channel2 = channel2();
        dialog_channel3 = (dialog_channel2 * dialog_channel1) * -1;
        //Listen
        //llListen(dialog_channel3,"","","");
        // Here Down is Self explanitory.
        llSay(0, "Hello, " + name);
   

    }
    }

This is the Error that i get in LsL editor:
*** Class, struct, or interface method must have a return type

The declarations of the global functions channel, channel2 and commandIs should be made outside of the state "default", in the same area as you declare your global variables. "top of script in functions" really does mean top of script.

(Edit) Looking closer, I see that the whole structure is wrong. Go to http://wiki.secondlife.com/wiki/LSL_Portal for references and examples of LSL scripting.

Basically, a script looks like this:

integer global_variable = 1;

integer GlobalFunction ()
{
return 1;
}

default
{
state_entry ()
{
integer scope_variable = 2;
global_variable = scope_variable + GlobalFunction ();
}
touch_start (integer number_of_touches)
{
state other;
}
}

state other
{
state_entry ()
{
integer another_scope_variable = 5;
global_variable = another_scope_variable + GlobalFunction ();
}
touch_start (integer number_of_touches)
{
state default;
}
}

stupid error in Cut & paste.

now i got another one

'channel' is a 'variable' but is used like a 'method'

referring to this line

dialog_channel1 = channel();

/me points at this line...


edit: and this my be the time for the semi-anual scripting tips preachy thing about coding style... As somebody who's been writing code for a RL living for more than a few years, I can tell you - without a doubt, no question about it, really listen to this - that a consistant coding style is important.


/me raises a rolled up newspaper threateningly..

You're mixing styles here. All but Key_ID are pretty consistant but Key_ID uses a different convention - you've cap'ed the K. Seems silly but this WILL come back to bite you at some point.

I'd have done...
integer gDialogChannel1;
integer gDialogChannel2;
integer gDialogChannel3;
key gKeyID;
string gName;

...which prefixes all global things with a 'g' and then uses camel case on the rest of the name.



/me thwaps Tabris on the nose with the rolled up newspaper. Same thing only different, and the cause of your 2nd post error.

If you consistantly use a format like you have on the 2nd function, and define globals as gSomeVariable, and define locals like someVariable, you won't run into that kind of problem again, you'll find your code is easier to read, and you won't run into evil scoping errors..

The style you pick doesn't really matter, as long as you consistantly follow it. Take what I use or not - doesn't matter to me. Just pick your style and stick to it. It will save you many, many hours of grief.

/me trips and falls as she climbs off the soap box.

Not enough here for me, at least, to figure out what's up. Can you post the whole script without the cut and paste error?

It continues to be the way the listen event is declared. It's got an argument named 'channel' which out-scopes the function named 'channel'.

/me dodges newspaper.

maybe i write like that to confuse people. (wrote an entire IT class essay in HEX)
i used to make all my variables/functions/other only something i could figure out.


but thanks any way. sorta works i just gotta tweak the last part in world.

Avoid global and local variable names, and also function names, that duplicate the parameter names of functions or event handlers. That's asking for BIG trouble. In most languages more localized scoping would take care of things for you, and you'd have some kind of syntax tool for distinguishing in any case when you really need to. LSL, on the other hand, tends to have hissy fits when you do stuff like that.