Script error AFTER the script works?

This script works. Click "Sit", and I go where I want, and the animation works, it's good. Except... When I stand up again, I get a script error about permissions not set. Anyone have any ideas?

key avatar;
vector pos = < 0.0,0.0,1.0>;
rotation rot = < 0.0,0.0,0.0,0.0>;

default
{
    state_entry()
    {
        llSitTarget(pos, rot);
    }
    changed(integer change)
    {
        avatar = llAvatarOnSitTarget();
       if(change & CHANGED_LINK)
       {
           if(avatar == NULL_KEY)
           {
                //  You have gotten off
                llStopAnimation("demure");
                llReleaseControls();
                llResetScript();
           }
           else if(avatar == llAvatarOnSitTarget())
           {
                llRequestPermissions(avatar,PERMISSION_TRIGGER_ANIMATION );
           }
        }
    }
        run_time_permissions(integer perms)
        {
        if(perms)
        {
            llStopAnimation("demure");
            llStartAnimation("demure");
        }
        else
        {
            llUnSit(avatar);
        }
    }
}

you can't stop the sit when they get up, because you lose permission to do so when that happens

For starters, try changing the line

else if(avatar == llAvatarOnSitTarget())

to simply say "else." After all, you set avatar = llAvatarOnSitTarget() a few lines earlier so the if test you wrote will always evaluate to TRUE.

I'm not sure why you have a llRelease Controls line in the script. It's also not clear to me why you stop and then immediately start the same animation in your run_time_permissions event.

ETA: And what she said.

To be honest, I stole this script from the library and started modifying it.

Thats the way we all start learning Before you know it you will become addicted and still be typing code wearily at 3 AM like the rest of us.

Try this ...

changed(integer change)
{
avatar = llAvatarOnSitTarget();
if(change & CHANGED_LINK)
{
if(avatar == NULL_KEY)
{
// You have gotten off
integer perm=llGetPermissions();
if ((perm & PERMISSION_TRIGGER_ANIMATION)
{
llStopAnimation("demure");
}
else 
{
llRequestPermissions(avatar,PERMISSION_TRIGGER_ANIMATION );
}
}
}
}
run_time_permissions(integer perms)
{
if(perms & PERMISSION_TRIGGER_ANIMATION)
{
llStopAnimation("sit");
llStartAnimation("demure");
}
else
{
llUnSit(avatar);
}
}
}

Yes, you _can_ normally stop animations after standing, and that script (only a different animation plugged in) works without error for me.

There is actually a JIRA entry exploring if permissions should be revoked on stand, but it's just a discussion now: https://jira.secondlife.com/browse/VWR-13228

You won't normally lose the permission at stand time, but _can_ run into trouble if the avatar ends up missing or in a different region, for example when logging out or teleporting before standing (if you aren't doing those, are you on a region boundary or something, or using a nonstandard viewer that tries to monkey with revoking permissions?).

To make the stop resistant to those problems, you can use:

                //  You have gotten off
                if (llGetAgentSize(llGetPermissionsKey())) {
                    llStopAnimation("demure");
                }

Thanks, I think I got it.

:macks forehead... Imma quit answering questions for today, I keep misremembering things =(

That's get away from the computer time, then!!! LSL melts brains, it's the only thing it does 100% consistently.

no, I can guarantee that reading and decoding unknown file formats in a hex editor will do it too...and much faster

There seems to be some timing dependencies, because I've had errors doing that too. Maybe it depends on what prim or event you stop the animation in.