Safe and Efficient Flow Control

Argh. The tab key is going to be the death of me, I swear. Anyway, here's the entire post:

I'm scripting something, and it's occurred to me that I can make some of my if-else statements shorter. That is, when I've got a situation like this:

if(test)
{
     do stuff 
     state NextState;
}
else
{
     do other stuff
}

I can turn it into this:

if(test)
{
     do stuff 
     state NextState;
}
do other stuff

My question is, is this safe? (Or any more efficient than just using else?) I don't want the script doing the "other stuff" even though the test is true. It seems like it should be okay, but I've had other things that ought to have been safe turn out not to be.

Yes, your change is safe and would be the way I would code that piece.

Of course, why not just:

if(code) state nextstate;
//do other stuff

And put your initial 'do stuff' into the state_entry() portion of your next state? You're headed there anyway...

My suggestion has NOTHING to do with performance or anything...just an extra throw in for organization.

Not really safe. Without the else it will do stuff and then when finished it will do other stuff.

It shouldn't do "other stuff".... but only because there is a state change. When execution returns to the default state from the NextState, it does not pick up where it left off.

Great! Your state change is acting as a virtual return!

iow

if (something_is_true) {doit (); return;}
if (something_else_is_true) {doit2 (); return;}

It would not pass Programming 101 but it helps the script fit inside the compiler's stack limits!