titler using strings?

i belive i may be doing this wrong, im creating a rp titler and it dosent seam to update at all cant figure out if this is the best way to do it or not, or even what i got wrong with this one

string name = "N/A";
string age = "N/A";
string weapon = "N/A";
vector color=<1,1,1>;
title()
{
    llSetText(
    "RP Info\n Name: "+(string)name
    +
    "\n Age: "+(string)age
    +
    "\nHidden Weapons: "+(string)weapon
    , color, 1.0);
}
default
{
        state_entry()
        {
                llListen( 5, "", llGetOwner(), "" );
                llSetTimerEvent(1);
        }
        listen( integer channel, string name, key id, string message )
        {
                string command = message;
                if (llGetSubString(command, 0, 4) == "name")
                {
                        name = llGetSubString(message, 5, -1);
                }
                else if (llGetSubString(command, 0, 3) == "age")
                {
                        age = llGetSubString(message,4, -1);
                }
                else if (llGetSubString(command, 0, 6) == "weapon")
                {
                        weapon = llGetSubString(message, 7, -1);
                }
                
        }
        timer()
        {
            title();
        }
        
}

I dont know much about titlers or how they operate but there is a few things i see wrong with this.

Firstly you have an insane timer speed and if you wanted it to update the title 1 second pause before it will do anything is like trying to stick your hand into hot water to fetch the money you just dropped into it , if you do it to fast you will miss picking up the money

the rest of the code i recognise as substrings but your best bet is to wait for others to try to help solve what your attempting but the link below i hope will provide a little info on how you might do it

http://www.lslwiki.net/lslwiki/wakka.php?wakka=LibraryMultiTitler

You may want to check you indicies for the llGetSubString functions. "name" would be 0 to 3, "age" 0 to 2 and "weapon" 0 to 5. I would also make the timer a bit longer otherwise you won't have time to say all your commands before it updates.

Throw away the timer entirely. Just put title() inside the listen event and it will update only if there is a change.

what jesse said

Yes QUite right Jesse.

Also I would consider using a List rather than a pile of string variables - then you could add in more "features" such as an inventory as you go along without having to do any code rewrites

You may also want to check if you have the running button checked in the lower left corner =P