Again, color change

I know this is a classic question, but i have some trouble with this script:

default
{
    
    on_rez(integer start_param)
    {
        llResetScript();
    }
    
    state_entry()
    {
        llSetColor(<1,0,0>, -1);
        llSetText("Busy", <1,0,0>, 1);
    }

    touch_start(integer num)
    {
    state on;
    }
    }

    state on
    {
    state_entry()
    {
        llSetColor(<1,0,0>, -1);
        llSetText("Empty", <1,1,1>, 1);
    }

    touch_start(integer num)
    {
    state default;
    }
}

The idea is a simple prim to change color and hovertext when touched, and back when touched again. Plain simple and stupid, lol, but as i'm no scripter, and work this out looking some other examples, something is wrong: the prim doesn't allow the touch. Like there is no script in it.

PS: i resolved the problem before sending this post...the script was not running!!...but i send it anyway...someone could find it helpful someday.

Here's your solution without the use of different states.

integer Toggle = FALSE;
string BusyText = "Busy!";
string NormText = "Not Busy...";

default
{
   on_rez(integer X) {llResetScript();}

   state_entry()
   {
	  llSetColor(<0,1,0>,ALL_SIDES);
	  llSetText(NormText,<0,1,0>,1);
   }

   touch_start(integer Count)
   {
	  Toggle = !Toggle;
	  if (Toggle)
	  {
		 llSetColor(<1,0,0>,ALL_SIDES);
  		 llSetText(BusyText,<1,0,0>,1);
 	  } else {
		 llSetColor(<0,1,0>,ALL_SIDES);
 		 llSetText(NormText,<0,1,0>,1);
 	  }
   }
}

Good...how both work, but how can i decide which "approach" is better?? Is there a "good" way of doing it and a "bad" one?

For something this simple, there is really no difference between the two worth worrying about; it boils down to a matter of taste. However, in a much more complex script, where you would change states frequently, it is often advised to use the single-state method over a multi-state method, because changing states has a significant bit of overheard attached to it that a single-state method does not.