Why ain't this working??????

The code below is suppose to take a list named test then look to see if llDetectedName is in the list. It works if llDetectedName is the first item in the list.

CheckAccess(list test)
{
AccessGranted = 0;
integer i = 0;
integer end = llGetListLength(test);
string AvDetected =llDetectedName(0);
for (; i<end; ++i)
{
string ListItem = llList2String(test, i);
if (AvDetected == ListItem)
{
AccessGranted = 1;
}
}
}

All comments appreciated.
RT

You may want to use llListFindList.

http://wiki.secondlife.com/wiki/LlListFindList

Not much info to go on here without seeing the code calling it. You might try it this way instead:

integer CheckAccess(list test)
{
    return llListFindList(test, [llDetectedName(0) ]) >= 0;
}

I assume this is being called from a touch event, since you are assuming that only the first detected name is significant. You might want to step from 0 through llDetectedName(num_detected - 1) to check all the detected names.

Be aware that llDetectedName() will only work within events that set it (sensor, touch, collision, etc). Otherwise it's meaningless.

Your function looks okay, have you printed out your list from memory to be sure that the other entries are present and not corrupted in some way?

to my recolection... you can't even use llDetected.. methods in your own functions even if they are called from e.g. a touch event... !?

however, since it's only a one-liner function, you can do without the function entirely and just use llListFindList

Lies, all lies! Who has been filling your head with such lies?!

Yes, you can invoke llDetected... from within functions, as long as you only call them from events where they are significant.

list_touchers(integer count)
{
    while (count--)
        llOwnerSay(llDetectedName(count));
}

default
{
    touch_start(integer total_number)
    {
        list_touchers(total_number);
    }
}

It's true that you can use llDetected* in functions called from sensor, touch etc events. However, doing so restricts where you can use the function in the future.

I'd recommend passing the name of the av in as a parameter, even though it's not strictly necessary in this case - you never know when you might need to do this again, but with an avatar name from a different source.

for (i; i<end; ++i), missing the first i in that statement.

Make that: for (i=0; i < end;++i) else the first expression would be quite useless.

doh

Can somebody test that? I think "integer i = 0; for ( ; i < 10; ++i)" is the same as "integer i; for (i = 0; i < 10; ++i)".

/me votes that this function is not being called from from an event that likes llDetected..

ok I've tried some of the suggestions made but still doesn't work so I'll post the whole script.

Ultimately what I am trying to accomplish with this is when someone touches the object if thier name is found in the list on the Configuration card then the script will run.

The Configuration card for this bit of code simply has a line in the following form.
AV1, Random Torok, AV2.

The list does seem to be valid because if I step through the elements of this list and display them they come up fine.

This script works if llDetectedName is the first element on the list.

//begin code
key ListKey;
string cName = "Configuration";
list Access;
integer AccessGranted;

CheckAccess(list test)
{
AccessGranted = 0;
integer i = 0;
integer end = llGetListLength(test);
string AvDetected =llDetectedName(0);
for (; i<end; ++i)
{
string ListItem = llList2String(test, i);
if (AvDetected == ListItem)
{
AccessGranted = 1;
}
}
}

default
{
state_entry()
{
ListKey = llGetNotecardLine(cName, 0);
}

dataserver(key query_id, string data)
{

if(query_id == ListKey)//Filtering the call
{
if (data != EOF) // not at the end of the notecard
{
Access = llParseString2List(data, [","],[]); //Give Access the same value as data.
//Data being what is read from the notecard
}
}
}
touch_start(integer total_number)
{
CheckAccess(Access);
if(AccessGranted == 1)
{
llSay(0, "You have access";
}
else
{
llSay(0, "You do not have access";
}
llResetScript();
}
}

//end code

I haven't tested it because I'm at work. But does your notecard have spaces after the commas? If it does, all av names except the first one will have a space in front of it, causing the comparison in CheckAccess to fail. And when you display them, they will probably look ok.

I was just about to guess that the notecard reading is funky, too..
Try this...

CheckAccess(list test)
{
	AccessGranted = 0;
	integer i = 0;
	integer end = llGetListLength(test);
	string AvDetected =llDetectedName(0);

	for (; i<end; ++i)
	{
		string ListItem = llList2String(test, i);
		llOwnerSay ("checking name '" + ListItem + "'");
		if (AvDetected == ListItem)
		{
			AccessGranted = 1;
		}
	}
}
[/
CODE

...and look closely at the output.

Or you could try hardcoding the list to check it, rather than reading it from a notecard.

So disable the notecard reading section, and replace

list Access;

with

list Access = ["AV1", "Random Torok", "AV2"];

at the top.

Thankyou everyone for your assistance. Stephen's suggestion did the trick. I took out the spaces after the commas and my code works great. Now to clean it up.

I had tried using a for loop to display the list but never noticed the extra space in there.

Just as a curiosity how would I get the llParseString2List function to cast off that space?

Thanks again to all.

llStringTrim - trims whitespace at the beginning, end or both of string. It only works on strings, not on lists of strings, so you'll either need to loop around the list of avs after you've read it from the notecard, or strip it when you do the comparison.

If you do the second way, it'll stop you replacing your loop with llFindListFind, which is something you probably want to do. So I'd add a function that takes the populated list of avs and cleans up any whitespace on each entry. Then call it after you've read your line from the notecard.

::: What Stephen Said :::

Random--

You could use the new llStringTrim function to strip of any leading or trailing spaces.

Here's an exampe:

llStringTrim(" Testing 1 2 3 ", STRING_TRIM);

Would produce:
"Testing 1 2 3"


p.s. Stephen beat me to it. I agree with Stephen, best to cleanup the AV list of names as you read/build your list. So have a temp list variable that can be used to parse the notecard record to a list, then append to the Access list variable using something like:

// where 'test' is the parsed-string-to-list from your notecard read

integer i;
integer end = llGetListLength(test);

for (i=0; i<end; ++i)
{
// Memory efficient way for appending new elements to a list
Access = (Access=[]) + Access + [llStringTrim(llList2String(test, i), STRING_TRIM)];
}

I think some of this would get easier if the notecard was changed to be one-line-per-name..

That and since you hit up the asset server on reset, it'd be more friendly to not reset the script unless you get a changed/INVENTORY event. Unless you have some other reason to reset it, of course.